pt-verb/conj

Fragment of a discussion from User talk:Rua

Agreed, the table generation code is not straightforward, but there are a few conditionals in there. It also combines the functionality of both {{pt-conj-2pp}} and {{pt-conj}}. As for the data-based approach, it is obviously not as powerful and elegant as a generative approach but simple to implement and understand.

My goal was to create a drop-in replacement for the current inflection code which would produce exactly the same output, with better performance and maintainability.

Once that is in place we can look at ways to replace the data with generators, I think Ungoliant_MMDCCLXIV (talkcontribs) had some ideas for that already. I'm a fan of doing refactorings step-by-step and not in one big swoop.

Jberkel (talk)18:27, 23 January 2015

I prefer doing it step by step as well. I guess it's just because I've done this many times already, I am able to skip some steps.

CodeCat20:17, 23 January 2015

I'd say let's keep the data the way it is for now, and I'll try your template based approach for the table generation to see if it can really simplify things.

Jberkel (talk)09:14, 24 January 2015

ok, I converted the table creation code to use templates instead of the mw.html builder. as a result it might now be a little bit easier to see whats going on, but in terms of lines of code required it's about the same for both versions. what do you think?

Jberkel (talk)02:24, 27 January 2015