Template talk:RQ:Hakluyt Principall Navigations
Module
editHi, @Erutuon, I was thinking of updating this quotation template so that instead of specifying a full URL, editors can also specify the Internet Archive page number (for example, |pageref=540 if the URL is https://archive.org/details/cihm_35668/page/n540/mode/1up) and the template will supply the full URL. However, I noticed you made this update to the template. What does it do? — SGconlaw (talk) 16:17, 4 August 2021 (UTC)
- @Sgconlaw: Nothing practically. That was just me moving a module. — Eru·tuon 18:39, 4 August 2021 (UTC)
- @Erutuon: I mean, what does the invocation of Module:reference information do for the template? — SGconlaw (talk) 18:51, 4 August 2021 (UTC)
- @Sgconlaw: I don't remember. I guess it generates the page URL. I thought you would have been the one to request me to add it in this edit but there's no discussion in Module talk:reference information so it must have been somewhere else. — Eru·tuon 19:26, 4 August 2021 (UTC)
- @Erutuon: hmmm, I don’t remember either! So currently does the template require the whole URL to be specified? Is it possible to update it so that an editor can also just specify the Internet Archive page using
|pageref=? — SGconlaw (talk) 02:27, 5 August 2021 (UTC)- @Sgconlaw: I took a look at the code. It uses the page number from the parameters
|page=,|2=, or|pageref=(whichever is specified first), named in the template invocation{{#invoke:reference information|retrieve|Hakluyt|pageurl|page|2|pageref}}.Hackluytis the table in Module:reference information/data that is retrieved from,pageurlis the name of the item that is retrieved. So it generates the|pageurl=parameter to{{quote-book}}from the page number. — Eru·tuon 03:00, 5 August 2021 (UTC)
- @Sgconlaw: I took a look at the code. It uses the page number from the parameters
- @Erutuon: hmmm, I don’t remember either! So currently does the template require the whole URL to be specified? Is it possible to update it so that an editor can also just specify the Internet Archive page using
- @Sgconlaw: I don't remember. I guess it generates the page URL. I thought you would have been the one to request me to add it in this edit but there's no discussion in Module talk:reference information so it must have been somewhere else. — Eru·tuon 19:26, 4 August 2021 (UTC)
- @Erutuon: I mean, what does the invocation of Module:reference information do for the template? — SGconlaw (talk) 18:51, 4 August 2021 (UTC)
The module again
edit@Erutuon: I updated this quotation template to allow for the 2nd edition of the work to be quoted from as well, and noticed that the first example (relating to the 1st edition) on the documentation subpage is not working properly. If page 460 of the work is specified, it should link to https://archive.org/details/cihm_35668/page/n497/mode/1up but it is actually linking to https://archive.org/details/cihm_35668/page/n494/mode/1up. It looks like Module:reference information/data needs correcting. (The pagination of the 1st edition may be very irregular; I haven't investigated it fully yet.) — SGconlaw (talk) 17:48, 7 February 2022 (UTC)