Module talk:quote

Issue with {{{chapter}}}/{{{entry}}}

Hi, @Benwing2, these parameters just stopped working. — SGconlaw (talk) 19:29, 9 March 2019 (UTC)

OK, think you've fixed it. Thanks. — SGconlaw (talk) 19:33, 9 March 2019 (UTC)

@Sgconlaw Yup. I was experimenting trying to reduce memory usage and accidentally committed some test code. Benwing2 (talk) 19:34, 9 March 2019 (UTC)

Turning maintenance messages into errors

@Sgconlaw Last night I turned off the test code that was using the old implementation in Template:quote-meta/source; now, the output of the Lua code is being used. I'm thinking of turning some maintenance messages into errors to make it more likely that people will notice the problems. I think I fixed all the existing pages that would trigger these issues. In particular, I'm thinking of making the following cases be errors:

1. Omitting the |lang=.
2. Specifying both |date= and |year=.
3. Specifying |archiveurl= without |archivedate=.
4. Specifying |archiveurl= without |url=.

Thoughts? Benwing2 (talk) 19:41, 9 March 2019 (UTC)

That sounds fine to me. — SGconlaw (talk) 19:44, 9 March 2019 (UTC)

@Sgconlaw I'm also thinking of implementing trans-* for authors, which should be easy now that the code is in Lua and won't require any change to the top-level templates Template:quote-book, Template:quote-journal, etc. Benwing2 (talk) 19:42, 9 March 2019 (UTC)

Could you elaborate? What would "trans-*" be for? — SGconlaw (talk) 19:44, 9 March 2019 (UTC)

@Sgconlaw For a transl(iter)ation of the author's name into English. In a lot of Russian quotes I ran into this issue, and would typically write |author=Пётр Ильич Чайковский (Pyotr Ilyich Tchaikovsky) where it might be better to write |author=Пётр Ильич Чайковский + |trans-author=Pyotr Ilyich Tchaikovsky. Note that the transliteration of Russian names into English is often idiosyncratic, e.g. "Tchaikovsky" is the standard transliteration but isn't terribly faithful to the Russian; our standard system would render it as Čajkovskij, and a less scientific system might use Chaykovskiy. (Rachmaninoff is even less accurate.) Benwing2 (talk) 20:40, 9 March 2019 (UTC)

Ah, I see. Sure. — SGconlaw (talk) 06:05, 10 March 2019 (UTC)

Error in {{quote-newsgroup}}

Hi, @Benwing2, in {{quote-newsgroup}} the message-id is appearing twice: see the template documentation and scouthouse (1994 quotation). — SGconlaw (talk) 16:53, 14 March 2019 (UTC)

@Sgconlaw This is because Module:quote directly supports the |id= parameter, and Template:quote-newsgroup also passes the |id= parameter as part of the |section= parameter. This probably "worked" before because Template:quote-newsgroup wasn't explicitly passing |id= to Template:quote-meta/source, but the Lua implementation passes all parameters through automatically unless explicitly overridden. Benwing2 (talk) 23:38, 14 March 2019 (UTC)

So how do we fix that? — SGconlaw (talk) 02:07, 15 March 2019 (UTC)

It depends on what you want to have happen. You could not pass the section= param in Template:quote-newsgroup, for example. Benwing2 (talk) 05:45, 15 March 2019 (UTC)

Ah, OK. I changed |section= to |id=. But is there some reason why we want it to appear in a smaller typeface? — SGconlaw (talk) 10:57, 15 March 2019 (UTC)

@Sgconlaw It appears in smaller typeface because that's what Template:quote-meta/source does. We can change that if you want. Benwing2 (talk) 17:00, 17 March 2019 (UTC)

Only one of year and date, but only date actually supplied

Odd error in oligomorph. — Eru·tuon 01:09, 16 March 2019 (UTC)

That's because |1= was supplied, which is passed to |year= by the template. Benwing2 (talk) 17:01, 17 March 2019 (UTC)

Issue with {{quote-song}}

@Benwing2: I noticed an issue with {{quote-song}} when |author= and |authorlink= are used: see jar (2010 quotation). — SGconlaw (talk) 16:20, 17 March 2019 (UTC)

@Sgconlaw This might be a similar issue as with {{quote-newsgroup}}; |authorlink= is automatically passed through, but the template also passes |authorlink= as part of |author=. What might be best is for me to implement a way of having the outer template disable passing a given param through. This would also work for {{quote-newsgroup}}. Benwing2 (talk) 17:05, 17 March 2019 (UTC)

I wonder why the issue doesn't arise with {{quote-book}} or {{quote-journal}}? — SGconlaw (talk) 17:41, 17 March 2019 (UTC)

@Sgconlaw The definitions of {{quote-book}} and {{quote-journal}} don't squash |authorlink= into |author=. Benwing2 (talk) 20:07, 17 March 2019 (UTC)

@Sgconlaw Fixed up {{quote-song}} and {{quote-newsgroup}}. Benwing2 (talk) 20:30, 17 March 2019 (UTC)

|quotee= does not appear unless |author= is present

• {{quote-book|mul|editor=EDITOR|quotee=QUOTEE|title=TITLE|year=1900}}
• {{quote-book|mul|author=AUTHOR|quotee=QUOTEE|title=TITLE|year=1900}}
• {{quote-book|mul|author=AUTHOR|editor=EDITOR|quotee=QUOTEE|title=TITLE|year=1900}}

produces

• 1900,, EDITOR, editor, TITLE:

• 1900, AUTHOR, quoting QUOTEE, TITLE:

• 1900, AUTHOR, quoting QUOTEE, EDITOR, editor, TITLE:

This does not seem to be desirable (extra comma and no QUOTEE). @Benwing2 Can this be fixed? —Suzukaze-c◇◇ 03:44, 12 January 2020 (UTC)

@Suzukaze-c Fixed. Benwing2 (talk) 14:17, 12 January 2020 (UTC)

Issue with a., c., and p. abbreviations in years

Hi, @Benwing2. Hi, if you have time could you look into the following issue, which seems to be related to this module? If |year= is preceded by a., c., or p., the module automatically creates a tooltip and a link to entries in "Wiktionary:Glossary" explaining that these abbreviations mean ante, circa, and post.

However, I've found that if anything is added after the year, for some reason it gets truncated. Thus, when I added to {{RQ:Beaumont Fletcher Comedies and Tragedies}} the following line under the |year= parameter:

| Bonduca|The Tragedie of Bonduca = c. 1613''' (first performance)'''​

what gets displayed (for example, at doubt) is "c. 1613 (", and everything else is truncated. (​ inserts a zero-width space, and is needed so that the bold markup doesn't choke.) I "fixed" this by changing this to "''c.''" in the quotation template, but this is not ideal as the abbreviation now appears bold, and the tooltip and link are gone. Any idea what is causing the problem? Thanks. — SGconlaw (talk) 08:56, 5 March 2020 (UTC)

@Sgconlaw Fixed. The issue was the regex in Module:time that removes the initial c., which was written incorrectly so that it removed any lowercase letter and following character rather than just a lowercase letter + following period at the beginning of the string. Benwing2 (talk) 21:22, 7 March 2020 (UTC)

@Benwing2: great, thank you! — SGconlaw (talk) 05:47, 8 March 2020 (UTC)

|2ndauthor=

@Sgconlaw |2ndauthor= (or |2ndfirst= and |2ndlast=) and |2ndauthorlink= are equivalent to |author= (or |first= and |last=) and |authorlink= for a new version; what are the equivalent parameters of |author2= (or |first2= and |last2=) and |authorlink2= (also |author3=, etc.) for a new version? J3133 (talk) 05:17, 26 May 2021 (UTC)

For simplicity, there aren’t any (that I’m aware of, anyway). Just put them all in |2ndauthor=. — SGconlaw (talk) 05:36, 26 May 2021 (UTC)

Suppressing a translation

@Benwing2: if the language of a work is not English, is there a way (or can you add a way) to suppress the requirement for an English translation to be added? See {{RQ:Promptorium parvulorum}}, a Middle English–Latin dictionary. It doesn't really make sense to call for a translation for this work. — SGconlaw (talk) 18:41, 22 August 2021 (UTC)

#invoke of call_quote_template

@Sgconlaw I added an interface onto {{quote-book}}. See {{RQ:Ascham Scholemaster}} for an example. If you write the code the way of this example, it automatically handles |text=, |passage=, |page=, |pages=, |footer= and |brackets= and |authorlink= (in the last case, not if you explicitly specify |authorlink=), so you don't have to give them explicitly. There are a few extra arguments you can pass in:

1. |template=: Name of template, instead of quote-book.
2. |textparam=: Name of text/passage param to use if neither |text= nor |passage= are given. Can be a comma-separated list of params; if so, the first such param with a specified value becomes the value of the text/passage param. Use |textparam=- to suppress auto-propagation of |text= and |passage=.
3. |pageparam=: Name of page param to use if |page= isn't given. Can be a comma-separated list of params; if so, the first such param with a specified value becomes the value of the page param. Use |pageparam=- to suppress auto-propagation of |page= and |pages=.
4. |propagateparams=: Comma-separated list of any additional params to propagate to the quote template, so you don't have to propagate them one-by-one.
5. |allowparams=: Comma-separated list of parameter to allow, in addition to the ones mentioned above (i.e. |text=, |passage=, |page=, |pages=, |footer= and |brackets= are automatically allowed, as are the parameters given in |textparam=, |pageparam= and |propagateparams=). This allows for parameter checking; you'll get an error if unrecognized parameters are specified. If the value is *, parameter checking is disabled.

This should make it easier for you to write new quotation templates with less boilerplate, and minimize the likelihood of forgetting some boilerplate. I am going to create a similar interface to make it easier to generate quotation template documentation. Benwing2 (talk) 22:23, 11 December 2021 (UTC)

Ah, I’ll check it out! By the way, could you check that the module is using “https” (for example, for links to WorldCat) where available? Thanks! — SGconlaw (talk) 04:32, 12 December 2021 (UTC)

Template:quote-meta/paramdoc

@Sgconlaw See {{quote-meta/paramdoc}} and example usage in Template:RQ:Pope Essay on Man/documentation. This currently supports the following replaceable params:

• <<page>> Text for the |page=/|pages= params.
• <<page:PARAM>> Text for the |page=/|pages= params where |PARAM= is an additional synonym.
• <<chapter>> Text for the |chapter= param when a chapter name should be provided.
• <<chapter:PARAM>> Text for the |chapter= param when a chapter name should be provided, where |PARAM= is an additional synonym.
• <<roman_chapter>> Text for the |chapter= param when an uppercase Roman numeral chapter number should be provided.
• <<roman_chapter:PARAM>> Text for the |chapter= param when an uppercase Roman numeral chapter number should be provided, where |PARAM= is an additional synonym.
• <<arabic_chapter>> Text for the |chapter= param when an Arabic numeral chapter number should be provided.
• <<arabic_chapter:PARAM>> Text for the |chapter= param when an Arabic numeral chapter number should be provided, where |PARAM= is an additional synonym.
• <<passage>> Text for the |text=/|passage= params.
• <<passage:PARAM>> Text for the |text=/|passage= params where |PARAM= is an additional synonym.
• <<trailing_params>> Text for additional params to mention at the end (currently |footer= and |brackets=).

It's pretty easy to add more replaceable params; you just need to let me know what the text should be. I'm also not sure that |page_nolink= is useful, and I'm aware that some templates have variant text of various sorts when describing the |page=/|pages= params; I'm not sure the best way to handle this. Benwing2 (talk) 00:25, 12 December 2021 (UTC)

Also note that tables may not be supported inside of template params; if you run into issues like this, move the table outside the call to {{quote-meta/paramdoc}}. Benwing2 (talk) 00:28, 12 December 2021 (UTC)

OK, will check it out. Thanks! — SGconlaw (talk) 04:33, 12 December 2021 (UTC)

Hope you will mention these on the documentation subpage too. — SGconlaw (talk) 07:25, 12 December 2021 (UTC)

Issue with |author=

@Benwing2: I think an edit you made to this module means that |author= no longer permits the wikilinking of authors in the form [[w:Guillaume de Salluste Du Bartas|Guillaume de Salluste Du Bartas]], which is sometimes needed: see this edit to {{RQ:Sylvester Du Bartas}}. — SGconlaw (talk) 17:09, 13 December 2021 (UTC)

@Sgconlaw I made it so that author= is automatically copied to authorlink= if authorlink= isn't explicitly given. Either you can add authorlink= explicitly, or I can change the code to not auto-populate authorlink=. Benwing2 (talk) 03:05, 14 December 2021 (UTC)

@Benwing2: I think it might be better not to auto-populate that parameter because there are a number of cases where parser functions are used with that parameter as different parts of a work have different authors, and it is more troublesome to have to repeat that coding with |authorlink=. Alternatively, I wonder if there is a way to auto-populate if that parameter contains a bare author name and nothing else? — SGconlaw (talk) 04:42, 14 December 2021 (UTC)

@Sgconlaw I fixed the auto-population so it doesn't do it if there are links or HTML in the |author= param. Benwing2 (talk) 05:13, 14 December 2021 (UTC)

@Benwing2: great! Thanks. — SGconlaw (talk) 05:14, 14 December 2021 (UTC)

Issue with |page2= and |pages2=

Hi, @Benwing2, page numbers specified using |page2= and |pages2= are appearing twice, once incorrectly as part of the original version of the work (which should only display page numbers specified using |page= and |pages=), and again correctly as part of the new version of the work: see {{RQ:Milton Collected Works}}. — SGconlaw (talk) 17:06, 14 December 2021 (UTC)

@Sgconlaw I think the issue here is that you are propagating |page= into |page2= and |pages= into |pages2=, while the module itself auto-propagates |page= and |pages= into the same-named underlying params. I added support for |pageparam=- to turn off auto-propagation of |page= and |pages= (and similarly |textparam=- to turn off auto-propagation of |text= and |passage=). With this added, the template seems to work properly. Benwing2 (talk) 03:40, 15 December 2021 (UTC)

@Benwing2: ah, I see. Thanks for the fix. It’s actually not uncommon to propagate |page= to |page2= in cases where the first edition of a work is not available online, and a modern reprint or republication is used in its place. — SGconlaw (talk) 04:53, 15 December 2021 (UTC)

@Sgconlaw If it's common enough, I can turn off auto-propagation of |page= and |pages=; but then if you want it propagated, you have to specify this explicitly using |pageparam= or |propagateparams=, or directly propagating the params yourself. Benwing2 (talk) 04:55, 15 December 2021 (UTC)

@Benwing2: I think it’s common enough for this to be turned off by default. The situations where separate page numbers are provided for the older and newer versions of the work are very uncommon, because usually a new version is only used when no old version is accessible online. How would the direct propagation need to be done, and can this all be documented somewhere? (Also, is |textparam=- needed? There is only one passage quoted in each template.) — SGconlaw (talk) 05:00, 15 December 2021 (UTC)

@Sgconlaw What I mean by direct propagation is writing something like this:

{{#invoke:quote|call_quote_template
|...
|page={{{3|{{{page|}}}}}}
|pages={{{pages|}}}
|...
}}

You can also get the same effect like this:

{{#invoke:quote|call_quote_template
|...
|pageparam=3,page
|pages={{{pages|}}}
|...
}}

or like this:

{{#invoke:quote|call_quote_template
|...
|pageparam=3,page
|propagateparams=pages
|...
}}

Benwing2 (talk) 05:14, 15 December 2021 (UTC)

@Benwing2: OK, I might take a while to get to grips with this. Just to check, using |pageparam= doesn’t automatically generate |pages=? If not, I think I’ve used it wrongly in some templates. — SGconlaw (talk) 05:26, 15 December 2021 (UTC)

@Sgconlaw It doesn't currently propagate |pages= but I'll make it do so if that helps you. What I can do is make |pageparam=, if used, propagate |page= and |pages=, and in addition convert whichever param or params are specified into |page=. That way, if you specify |pageparam=3, for example, it's equivalent to specifying

|page={{{3|{{{page|}}}}}}
|pages={{{pages|}}}

but if you don't specify |pageparam=, then neither |page= nor |pages= is auto-propagated. Does that make sense to you? BTW I added documentation on {{#invoke:quote|call_quote_template}} to Module:quote/documentation. Benwing2 (talk) 05:30, 15 December 2021 (UTC)

@Benwing2: yes, thanks! — SGconlaw (talk) 10:06, 15 December 2021 (UTC)

@Sgconlaw Should be implemented. Benwing2 (talk) 14:03, 15 December 2021 (UTC)

Add date_published

@Benwing2 Can we add this to complete the cross product? We have year, date and year_published. It just silently failed for me in Aufblaser. — Fytcha〈 T | L | C 〉 15:47, 10 January 2022 (UTC)

ISSN

Would it be possible to make this accept eight-digit ISSNs with no hyphen by just adding it automatically? 70.172.194.25 01:36, 14 January 2022 (UTC)

Archiveurl and Archivedate

@Ioaxxere: thanks for the edit which makes it unnecessary to specify |archivedate= if the archive URL is from the Internet Archive. Can I suggest that in those situations the template need not put the entry into “Category:Quotations using archiveurl without archivedate”? I think the category should be retained in case other archive websites are used. Also, would it be possible to update {{cite-meta}} so that it works the same way to Module:quote? However, it hasn’t been “Lua-ified” yet. — Sgconlaw (talk) 21:44, 7 January 2023 (UTC)

I didn't know about that category⁠—looks to be full of my entries :)

I think that should be fixed now, and I already see entries starting to drop out of the category. As for {{cite-meta}}, I can't update that until I get the Template Editor rights. Ioaxxere (talk) 23:08, 7 January 2023 (UTC)

@Ioaxxere: thanks! Regarding {{cite-meta}}, would it be possible for you to work on an update in a sandbox, for example, a subpage of your user page? — Sgconlaw (talk) 06:49, 8 January 2023 (UTC)

OK, I think I've got the update set up but it would be convenient to be able to preview it on a few real entries to make sure nothing has gone wrong. I'll see if I can get the permissions. Ioaxxere (talk) 17:45, 8 January 2023 (UTC)

@Ioaxxere: OK, good luck! — Sgconlaw (talk) 18:10, 8 January 2023 (UTC)

@Sgconlaw done. Is there another hidden category filling up with entries now? (edit: there was) Ioaxxere (talk) 19:28, 7 February 2023 (UTC)

{{{volume_plain}}

@Benwing2: this parameter seems to have stopped working: see {{RQ:Hardy Dynasts}}. — Sgconlaw (talk) 22:10, 3 August 2023 (UTC)

Date bug

@Benwing2 (pinging per your edit summary "total rewrite of date formatting functionality"): |date=1 April 2023 is displaying as 2023 April (without the day) in the last quote on breast boobily. Ioaxxere (talk) 13:31, 7 August 2023 (UTC)

@Ioaxxere Thanks. It is trying to figure out whether to display the day or not and seems to be messing up. Benwing2 (talk) 14:09, 7 August 2023 (UTC)

Archive links bug

@Benwing2 The superscript links on the Twitter quotes at scrunkly are targeting the original URL rather than the archive URL. Ioaxxere (talk) 17:55, 27 August 2023 (UTC)

No script/language with w:LANG:

• {{quote-book|ja|author=ja:尾田栄一郎}} → Jpan, ja

  (Can we date this quote?), 尾田栄一郎, (Please provide the book title or journal name):

• {{quote-book|ja|author=w:ja:尾田栄一郎}} → Hani, und

  (Can we date this quote?), 尾田栄一郎, (Please provide the book title or journal name):

@Benwing2 —Fish bowl (talk) 23:35, 1 November 2023 (UTC)

@Fish bowl Sorry, I missed this. Try using the lw: prefix; the w: prefix doesn't do script detection because Wikipedia codes may not be valid for Wiktionary. See Template:quote-book/documentation#Parameters. Possibly I should make this smarter so that it knows which language codes are the same in Wikipedia and Wiktionary and does automatic script detection for those. Benwing2 (talk) 00:29, 6 February 2024 (UTC)

Year is repeated with different months

@Benwing2:

2024 January–December, (Please provide the book title or journal name):

{{quote-book|en|start_month=January|start_year=2024|month=December|year=2024}} displays “2024 January – 2024 December” instead of “2024 January–December”. I was unable to find out the reason. J3133 (talk) 06:13, 4 February 2024 (UTC)

@J3133 Let me take a look. I notice that using |start_date= and |date= works for some reason, e.g. {{quote-book|en|start_date=2022-01|date=2022-02}}. Benwing2 (talk) 00:35, 6 February 2024 (UTC)

Fixed. Benwing2 (talk) 00:55, 6 February 2024 (UTC)

date_published

@Sgconlaw: Should this parameter not be used? J3133 (talk) 08:11, 18 February 2024 (UTC)

It was making the publication date appear in an odd year-month-day format in the middle of the citation. I didn’t even know this parameter had been added to the module. If it’s only used in the middle of the citation, perhaps it should be changed to use a day-month-year format. — Sgconlaw (talk) 13:22, 18 February 2024 (UTC)

@Benwing2: Will you change this? J3133 (talk) 15:05, 18 February 2024 (UTC)

|archiveurl= not working properly with {{quote-journal}}

@Ioaxxere, Benwing2: this module had been updated by Ioaxxere so it is not necessary to use {{archivedate}} |url= if |archiveurl= contains an Internet Archive Wayback Machine URL, but this doesn't seem to be working for {{quote-journal}}—see the noun section of transgender, where the 2004 quotation under sense 2 is throwing a Lua error. — Sgconlaw (talk) 21:20, 15 March 2024 (UTC)

@Sgconlaw This seems to be a different error. The change by @Ioaxxere was for |archivedate= vs. |archiveurl=, but this is for |archiveurl= vs. |url=. What should the behavior be? Benwing2 (talk) 21:34, 15 March 2024 (UTC)

@Benwing2: ah, sorry. I meant |url=. It shouldn't be necessary to use both that parameter and |archiveurl= if the latter contains an IA Wayback Machine URL—at least that's how it works for {{quote-book}}. — Sgconlaw (talk) 21:39, 15 March 2024 (UTC)

@Benwing: oh, I know what the problem is. The IA link is not to the Wayback Machine after all, which has URLs in the format https://web.archive.org/web/20240313154607/https://www.theguardian.com/guardian-observer-style-guide-t, but it is to the text section which has URLs in the format https://archive.org/details/transgender-warriors-making-history-from-joan-of-arc-to-dennis-rodman-feinberg-leslie-1949/Lavender_and_Red/page/n8/mode/1up. However, because of this, there isn't any separate value which can be given to |url=. I suppose that in a case like this I should just specify the IA URL under |url=. — Sgconlaw (talk) 22:28, 15 March 2024 (UTC)

@Sgconlaw OK sounds good, glad it's straightened out. Benwing2 (talk) 23:18, 15 March 2024 (UTC)

Stopping automatic linking of author to Wikipedia article if none exists

@Benwing2: when |author= is used, is there a way to prevent the module from trying to link to a Wikipedia article about an author when none exists? — Sgconlaw (talk) 19:01, 16 March 2024 (UTC)

@Benwing2: just flagging this up as an issue again—hope you can look into it when you are free. See, for example, what happens with the entry {{RQ:Guardian 1713}} at "Wiktionary:Quotations/Templates/English S#Steele, Richard". — Sgconlaw (talk) 16:09, 15 April 2024 (UTC)

@Sgconlaw Sorry I didn't realize this is still an issue; sometimes it's not clear to me what is or isn't fixed. I will take a look shortly. Benwing2 (talk) 19:12, 16 April 2024 (UTC)

@Sgconlaw It looks like this is happening in call_quote_template() because that function automatically copies |author= to |authorlink= in most circumstances. I fixed it so that it won't do this if an embedded HTML-encoded left bracket ([) is present, but in general you can disable this by adding a blank param |authorlink= to the call to call_quote_template(). Benwing2 (talk) 21:06, 16 April 2024 (UTC)

@Benwing2: thanks. So, just to clarify, if there is no need to mark up the author's name in any way, but just to stop the template from incorrectly linking to a non-existent Wikipedia article, I should type the following? (I am thinking it might be better to put a comment, otherwise another editor might come along and remove the |authorlink= parameter.)

|author = Joe Bloggs

|authorlink =<!--No Wikipedia article-->

Alternatively, would it be a good idea to allow editors to type |authorlink=- to suppress the attempted linking? — Sgconlaw (talk) 21:27, 16 April 2024 (UTC)

@Sgconlaw I agree and I have added that functionality. Benwing2 (talk) 21:36, 16 April 2024 (UTC)

@Benwing2: great! Thanks for working on this. — Sgconlaw (talk) 21:41, 16 April 2024 (UTC)

support cite- template formatting

Over at Module:User:JeffDoozan/quote, I have a fork of this module where I've added support for the citation formatting used by the cite- templates. I've tested the patched module with all of the existing quote- calls to verify that the output of is identical to this module and I've reviewed the differences between output of the original cite- templates and that produced by the new module (see User:JeffDoozan/cite-book/tests, User:JeffDoozan/cite-web/tests, User:JeffDoozan/cite-journal/tests, User:JeffDoozan/cite-av/tests, User:JeffDoozan/cite-song/tests and User:JeffDoozan/cite-newsgroup/tests for a sample of each). I'd like to merge those changes into this module and switch the existing cite- templates to use this module. I've tried to make the changes as clean as possible by adding export.cite_t() as the primary interface for cite- templates and adding a format_as_cite flag to export.source() and postauthor(), but I'd appreciate any comments on the quality of the new code or differences in the old/new cite template outputs. @Benwing2 @Sgconlaw JeffDoozan (talk) 18:02, 10 April 2024 (UTC)

@JeffDoozan I took a look at your code, and as far as I can tell the approach is correct. The use of the format_as_cite flag rather than just forking the whole thing is definitely the right approach; otherwise we'd have to maintain two versions, which would inevitably get out of sync. You should test the code to make sure it still generates quotations correctly; I have a whole bunch of calls to {{quote-*}} in User:Benwing2/test-quote that exercise different parts of the module, which might help. If everything checks out, I would support merging these changes into the production module (BTW the production module includes some recent optimizations by User:Theknightwho). Benwing2 (talk) 03:28, 12 April 2024 (UTC)

Oh one thing I forgot ... what about invalid parameters? I'm sure there are a zillion of them collectively for all the cite templates, unless you've somehow cleaned them all up. Benwing2 (talk) 03:29, 12 April 2024 (UTC)

Thanks for the tests, looks like everything matches: User:JeffDoozan/test-quote. I've cleaned up many of the invalid parameters, and the rest are handled in export.cite_t() by wrapping everything with pcall() and then falling back to the old template and adding a maintenance category in case of errors. Once this is in production and the categories fill up, I'll clean up the remaining invalid parameters and remove the pcall JeffDoozan (talk) 13:57, 12 April 2024 (UTC)

┌────────────────────────────────────────────────────────────────────────────────────────────────────┘ Hi @JeffDoozan, the switching-over of the cite templates to use Module:quote has inadvertently created line-break issues—see footnotes 4 and 5 in the "References" section of milliner. Seems like there's a redundant carriage return after the reference. (I recall that this happens with the quote templates too, but with them perhaps this behaviour is correct.) — Sgconlaw (talk) 19:09, 12 April 2024 (UTC)

@Sgconlaw: Thanks, I reverted the changes to {{cite-web}} while I track down the errant carriage return (it's the only widely-used template that I've converted so far). JeffDoozan (talk) 19:18, 12 April 2024 (UTC)

 fixed it was an HTML issue, using a div tag instead of a span. JeffDoozan (talk) 19:30, 12 April 2024 (UTC)

@JeffDoozan: excellent! Thanks. — Sgconlaw (talk) 20:13, 12 April 2024 (UTC)

@JeffDoozan I noticed that the display of the external link in {{R:GDoS}} (which uses {{cite-web}}) recently changed and I think it might be related to your recent changes in the module (I might be wrong). I've now edited the reference template to match the earlier format but other templates may also be affected. Einstein2 (talk) 23:03, 14 April 2024 (UTC)

@Einstein2: Thanks for mentioning this. Many of the templates got converted automatically if they contained PAGENAME or "/page/" in the url. I'll do another pass to convert urls that contain variables. JeffDoozan (talk) 23:09, 14 April 2024 (UTC)